Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use inject #1840

Merged
merged 1 commit into from
Jun 13, 2024
Merged

feat: use inject #1840

merged 1 commit into from
Jun 13, 2024

Conversation

matthieu-crouzet
Copy link
Contributor

@matthieu-crouzet matthieu-crouzet commented May 31, 2024

Proposed change

Use inject to reduce the boilerplate code, and simplify the DI

@matthieu-crouzet matthieu-crouzet requested a review from a team as a code owner May 31, 2024 07:44
sdo-1A
sdo-1A previously approved these changes May 31, 2024
fpaul-1A
fpaul-1A previously approved these changes Jun 10, 2024
@matthieu-crouzet matthieu-crouzet added this pull request to the merge queue Jun 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 12, 2024
@matthieu-crouzet matthieu-crouzet added this pull request to the merge queue Jun 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 13, 2024
@matthieu-crouzet matthieu-crouzet added this pull request to the merge queue Jun 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 13, 2024
@matthieu-crouzet matthieu-crouzet added this pull request to the merge queue Jun 13, 2024
Merged via the queue into main with commit f9795ae Jun 13, 2024
28 checks passed
@matthieu-crouzet matthieu-crouzet deleted the fix/use-inject branch June 13, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants