-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use inject #1840
Merged
Merged
feat: use inject #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
New feature or request
project:@o3r/showcase
labels
May 31, 2024
sdo-1A
previously approved these changes
May 31, 2024
matthieu-crouzet
force-pushed
the
fix/use-inject
branch
from
May 31, 2024 14:25
f37eb7b
to
ebf14f7
Compare
mrednic-1A
reviewed
Jun 3, 2024
fpaul-1A
reviewed
Jun 3, 2024
matthieu-crouzet
force-pushed
the
fix/use-inject
branch
from
June 3, 2024 15:22
ebf14f7
to
7739d84
Compare
matthieu-crouzet
force-pushed
the
fix/use-inject
branch
4 times, most recently
from
June 10, 2024 14:56
1cf5c9b
to
1212966
Compare
fpaul-1A
reviewed
Jun 10, 2024
fpaul-1A
reviewed
Jun 10, 2024
apps/showcase/src/components/showcase/design-token/design-token-pres.component.ts
Show resolved
Hide resolved
fpaul-1A
previously approved these changes
Jun 10, 2024
matthieu-crouzet
force-pushed
the
fix/use-inject
branch
from
June 10, 2024 15:54
1212966
to
c8d4fe6
Compare
fpaul-1A
approved these changes
Jun 10, 2024
cpaulve-1A
reviewed
Jun 11, 2024
...owcase/src/components/showcase/component-replacement/component-replacement-pres.component.ts
Show resolved
Hide resolved
cpaulve-1A
reviewed
Jun 11, 2024
apps/showcase/src/components/showcase/rules-engine/rules-engine-pres.component.ts
Show resolved
Hide resolved
cpaulve-1A
approved these changes
Jun 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Jun 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jun 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Use
inject
to reduce the boilerplate code, and simplify the DI