Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add the possibility to specify action types to invoke the reducer in the storage sync helper #1320
base: release/9.6
Are you sure you want to change the base?
feat: Add the possibility to specify action types to invoke the reducer in the storage sync helper #1320
Changes from all commits
97a95a0
12e9f0a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should check
syncForFeature
whenaction.type
is notINIT
I don't understand why we need
RECOMPUTE
because
UPDATE
will be called when loading the lazy loaded store, and it should be enough no ?RECOMPUTE
seems to be for devtools so in production mode it will not be called no ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the check. Also, for the second question, we need
RECOMPUTE
because in dev mode, we get an undefined state for bothUPDATE
andRECOMPUTE
action types even if the reducer is invoked forUPDATE
, the state arrives as undefined forRECOMPUTE
. Hence, the app breaks and is not usable.Please check the reproduction: https://github.com/Abhirocks889/store-sync-error