-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): expose the placeholder service in @o3r/components #1621
Draft
kpanot
wants to merge
1
commit into
main
Choose a base branch
from
feature/placeholder-expose-service
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
232ea58
to
151f16a
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a3105cc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
30d0655
to
b47b02c
Compare
sdo-1A
reviewed
Apr 16, 2024
packages/@o3r/components/src/tools/placeholder/placeholder.interface.ts
Outdated
Show resolved
Hide resolved
mrednic-1A
reviewed
Apr 18, 2024
mrednic-1A
reviewed
Apr 18, 2024
packages/@o3r/components/src/stores/placeholder-effect/placeholder.effect.ts
Outdated
Show resolved
Hide resolved
e1c30a4
to
ce47122
Compare
ce47122
to
f44d554
Compare
42d8a98
to
32a5ea7
Compare
…ed without rule-engine
32a5ea7
to
a3105cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Expose the service to provide Placeholder Template URLs in the
@o3r/components
package instead on the rules engine.The next (followed by #1617) is let the Effect also accessible via
@o3r/components
Related issues