feat(chrome-ext): palette generator #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieu-crouzet
force-pushed
the
feat/chrome-palette
branch
from
8171117
to
9b69b56
Compare
github-actions
bot
added
enhancement
matthieu-crouzet
force-pushed
the
feat/chrome-palette
branch
4 times, most recently
from
f8b0a16
to
28796ea
Compare
kpanot
reviewed
Apr 17, 2024
apps/chrome-devtools/src/app-devtools/theming-panel/theming-panel-pres.component.ts
Outdated
Show resolved
Hide resolved
matthieu-crouzet
force-pushed
the
feat/chrome-palette
branch
from
28796ea
to
a07e1c4
Compare
kpanot
previously approved these changes
Apr 17, 2024
matthieu-crouzet
force-pushed
the
feat/chrome-palette
branch
3 times, most recently
from
fbefd1a
to
baf84c7
Compare
fpaul-1A
reviewed
Apr 18, 2024
fpaul-1A
reviewed
Apr 18, 2024
| </div> | ||
| <label class="form-label text-nowrap fw-semibold my-0 ms-4" [for]="group.name">{{ group.name }}</label> | ||
| @if (form.value.variables?.[group.defaultVariable.name] !== group.defaultVariable.defaultValue) { | ||
| <i class="form-text text-warning icon-undo position-absolute end-0 me-10" ngbTooltip="Reset all colors of {{group.name}}" (click)="onPaletteReset(group, $event)"></i> |
There was a problem hiding this comment.
I don't think it's a good practice in terms of accessibility to have a clickable element inside the header of the accordion which is already clickable
fpaul-1A
previously approved these changes
Apr 18, 2024
cpaulve-1A
reviewed
Apr 18, 2024
cpaulve-1A
reviewed
Apr 18, 2024
apps/chrome-devtools/src/app-devtools/theming-panel/color.pipe.ts
Outdated
Show resolved
Hide resolved
cpaulve-1A
reviewed
Apr 18, 2024
| <span class="my-auto">{{ resolvedColor }}</span> | ||
| <span class="ms-auto my-auto"> | ||
| <span ngbTooltip="Accessibility score for small text" [style.fontSize]="'12px'" class="me-2">{{ resolvedColor | accessibilityConstrastScore : (resolvedColor | contrast) : 'small' }}</span> | ||
| <span ngbTooltip="Accessibility score for large text" [style.fontSize]="'24px'">{{ resolvedColor | accessibilityConstrastScore : (resolvedColor | contrast) : 'large' }}</span> |
There was a problem hiding this comment.
why use style.fontSize and use a hard coded value?
There was a problem hiding this comment.
hardcoded value because for accessibility large text start at 24px and for small text I picked 12px to let the user see a big difference between large and small without having it too small to be read
There was a problem hiding this comment.
for [style.fontSize]="'24px'" I found it clearer than style="{font-size: 24px'} and Angular provide autocomplete for [style.<...>]
matthieu-crouzet
force-pushed
the
feat/chrome-palette
branch
from
baf84c7
to
4308fa3
Compare
fpaul-1A
previously approved these changes
Apr 18, 2024
matthieu-crouzet
force-pushed
the
feat/chrome-palette
branch
5 times, most recently
from
68f590f
to
e38991b
Compare
fpaul-1A
reviewed
Apr 19, 2024
matthieu-crouzet
force-pushed
the
feat/chrome-palette
branch
from
e38991b
to
ddd43f4
Compare
fpaul-1A
approved these changes
Apr 19, 2024
cpaulve-1A
approved these changes
Apr 19, 2024
kpanot
reviewed
Apr 19, 2024
| @@ -94,6 +95,7 @@ | |||
| "@o3r/components": "workspace:^", | |||
| "@o3r/configuration": "workspace:^", | |||
| "@o3r/core": "workspace:^", | |||
| "@o3r/design": "workspace:^", | |||
There was a problem hiding this comment.
True I will fix it in another PR as this one is merged :)
| standalone: true | ||
| }) | ||
| export class ColorPipe implements PipeTransform { |
There was a problem hiding this comment.
isn't this a breaking change?
There was a problem hiding this comment.
That's an internal pipe expose only in this folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Related issues