feat(localization): add schema for localization.json files #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 62028f3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
github-actions
bot
added
enhancement
fpaul-1A
reviewed
Apr 25, 2024
packages/@o3r/localization/builders/helpers/localization.generator.ts
Outdated
Show resolved
Hide resolved
fpaul-1A
reviewed
Apr 25, 2024
| }, | ||
| "dictionary": { | ||
| "type": "boolean", | ||
| "description": "Determine if the item can have multiple extensions", |
There was a problem hiding this comment.
does this description really match what this field does ?
There was a problem hiding this comment.
Just used the description from TS interface, it is not perfect but not wrong.
Basically it determines that the key can have a .<somthing> suffix.
If you have better, I take it :)
kpanot
force-pushed
the
feature/localization-schema
branch
from
ca5444e
to
49a5d34
Compare
kpanot
force-pushed
the
feature/localization-schema
branch
from
49a5d34
to
62028f3
Compare
mrednic-1A
approved these changes
Apr 29, 2024
fpaul-1A
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add localization.json files JSON Schema
Related issues