[cascading] from release/10.3.0-rc to main #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![otter-cascading[bot]](https://avatars.githubusercontent.com/in/318094?s=60&v=4){kind=small}
## Proposed change <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that is required for this change. --> ## Related issues - 🐛 Fixes #(issue) - 🚀 Feature #(issue) <!-- Please make sure to follow the contributing guidelines on https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md --> - the list of **ids** in the entities store was restricted to: **string[] | number[]** - the pb is that when passing an array of strings, tsc is complaining about the fact that a _string_ is not assignable to a _number_, because it cannot fulfill both conditions (the opposite is the same). That's why I changed the type to (string | number)[] to be restrictive only to the element and not to the entire array.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8b0ac94. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
mrednic-1A
approved these changes
May 6, 2024
kpanot
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cascading from release/10.3.0-rc to main
The configuration requests the cascading to bypass reviewer in case of CI success.
To not bypass the reviewing process, please check the following checkbox:
This Pull Request has been generated with ❤️ by the Otter cascading tool.