Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chrome-ext): support states #1787

Merged
merged 3 commits into from
Jul 18, 2024
Merged

feat(chrome-ext): support states #1787

merged 3 commits into from
Jul 18, 2024

Conversation

matthieu-crouzet
Copy link
Contributor

@matthieu-crouzet matthieu-crouzet commented May 15, 2024 •
edited

Proposed change

image

  • Add current language in state (if has been changed?)
  • Add the schema in state json exported file
  • Validate the json imported file with the schema
  • Add reset button when configuration is changed
  • Choose between the save of only the override or all the current value
    • Split this choice by category (theming / localization / configuration / language)
  • Support the capability to close the chrome extension and reopen without loosing unsaved changes
    • Or find a way to block the closing of the devtools if unsaved changes and ask if they want to save it or not
  • Add capability to let the app select the state to activate on bootstrap (query param?)
  • Move the save button in the select of the states and remove the warning border
  • Add new import state methods
    • By URL
    • By textarea

Related issues

@matthieu-crouzet matthieu-crouzet requested a review from a team as a code owner May 15, 2024 08:24
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 15, 2024 •
edited

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d046131. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@matthieu-crouzet matthieu-crouzet force-pushed the feat/chrome-state branch 2 times, most recently from 774047e to afd4fd2 Compare May 15, 2024 11:43
sdo-1A
sdo-1A reviewed May 17, 2024
View reviewed changes
apps/chrome-devtools/src/app-devtools/state-panel/state-panel.component.ts
@Component({
selector: 'o3r-state-panel',
templateUrl: './state-panel.template.html',
styles: `
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the styles be in an scss file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both solutions are okay

@sdo-1A
Copy link
Contributor

sdo-1A commented May 17, 2024 •
edited by cpaulve-1A

add the state feature to the apps/chrome-devtools/README.md

Edit; covered in #1962

@matthieu-crouzet matthieu-crouzet force-pushed the feat/chrome-state branch 3 times, most recently from d9cfc16 to 6bdd008 Compare May 17, 2024 14:35
sdo-1A
sdo-1A previously approved these changes May 17, 2024
View reviewed changes
kpanot
kpanot reviewed May 20, 2024
View reviewed changes
apps/chrome-devtools/schemas/state.schema.json Show resolved Hide resolved
apps/chrome-devtools/src/app-devtools/app.component.html Outdated Show resolved Hide resolved
apps/chrome-devtools/src/manifest.json
@@ -7,6 +7,7 @@
"permissions": [
"activeTab",
"scripting",
"storage",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not forget to add a justification to this permission to the Chrome Developer Portal when publishing this new version (Otherwise the publication maybe rejected)

@cpaulve-1A
Copy link
Contributor

cpaulve-1A commented May 27, 2024 •
edited

We need to provide a documentation to help a user with this feature.
It should answer the following questions:

  • how to whitelist a domain
  • how to activate a state - do they need to do it manually on the extension via the debugger tool or is it automatic?
  • do we support the same state in two different tabs ? (What happens in this case?)

Edit: new Issue create to cover this #1962

@cpaulve-1A cpaulve-1A changed the base branch from main to release/11.0.0-rc July 8, 2024 09:50
@cpaulve-1A cpaulve-1A changed the base branch from release/11.0.0-rc to main July 8, 2024 10:09
@cpaulve-1A cpaulve-1A mentioned this pull request Jul 11, 2024
Open
@github-actions github-actions bot added breaking change This issue or pull request introduces a breaking change project:@ama-sdk/schematics project:@o3r/github-cascading-app labels Jul 11, 2024
@cpaulve-1A cpaulve-1A mentioned this pull request Jul 11, 2024
Open
fpaul-1A
fpaul-1A reviewed Jul 12, 2024
View reviewed changes
apps/chrome-devtools/src/app-devtools/app.component.ts
Comment on lines +85 to 87
public stateCompareWithFn(state: State, selectedStateName: string) {
return state.name === selectedStateName;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public stateCompareWithFn(state: State, selectedStateName: string) {
return state.name === selectedStateName;
}
public stateCompareWithFn = (state: State, selectedStateName: string) => state.name === selectedStateName;

there is no problem here but if we were to use this, it could lead to some issues as this method is passed as input in the template and lose the component context (I assume)

@cpaulve-1A cpaulve-1A changed the base branch from main to release/11.0.0-rc July 15, 2024 07:30
@cpaulve-1A cpaulve-1A removed bug Something isn't working breaking change This issue or pull request introduces a breaking change labels Jul 15, 2024
vscaiceanu-1a
vscaiceanu-1a previously approved these changes Jul 15, 2024
View reviewed changes
@cpaulve-1A cpaulve-1A force-pushed the feat/chrome-state branch 2 times, most recently from ce42773 to b6c3c37 Compare July 16, 2024 14:26
mrednic-1A
mrednic-1A approved these changes Jul 18, 2024
View reviewed changes
apps/chrome-devtools/src/services/ruleset-history.service.ts
const extensionMessage = toSignal(this.connectionService.message$.pipe(filter(isRuleEngineEventsMessage)));
effect(() => {
const message = extensionMessage();
if (message) {
Copy link
Contributor

@mrednic-1A mrednic-1A Jul 17, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not blocking: not needed to check the 'undefined' case as it is handled in the filter callback

matthieu-crouzet and others added 3 commits July 18, 2024 14:48
@matthieu-crouzet @cpaulve-1A
feat(chrome-ext): support states
3130346
@cpaulve-1A
feat(chrome-extension): improve performance on localization panel
3218047 
Limit the number of key translation displayed and only create inputs for displayed items

Encourage the user to use the search bar to find their translation
@cpaulve-1A
chore: add tsdoc and correct various bugs
d046131 
Fix issue on localization not available when currentLanguage or lang list is not set
Add tsdoc and json schema description
Handle the app connection state with signals
Add new option.html in nx input/output to avoid future cache issue
@cpaulve-1A cpaulve-1A merged commit f6941f6 into release/11.0.0-rc Jul 18, 2024
20 checks passed
@cpaulve-1A cpaulve-1A deleted the feat/chrome-state branch July 18, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpanot kpanot kpanot left review comments

@cpaulve-1A cpaulve-1A cpaulve-1A left review comments

@mrednic-1A mrednic-1A mrednic-1A approved these changes

@fpaul-1A fpaul-1A fpaul-1A approved these changes

@vscaiceanu-1a vscaiceanu-1a vscaiceanu-1a left review comments

@sdo-1A sdo-1A sdo-1A left review comments

Assignees
No one assigned
Labels
enhancement New feature or request project:@ama-sdk/schematics project:@o3r/application project:@o3r/chrome-devtools project:@o3r/github-cascading-app project:@o3r/localization project:@o3r/showcase project:@o3r/styling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@matthieu-crouzet @sdo-1A @cpaulve-1A @kpanot @vscaiceanu-1a @mrednic-1A @fpaul-1A