-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing css variables in chrome dev-tool #1967
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/@o3r/styling/src/devkit/styling-devtools.message.service.ts
Outdated
Show resolved
Hide resolved
vscaiceanu-1a
previously approved these changes
Jul 15, 2024
fpaul-1A
previously approved these changes
Jul 15, 2024
Do not remove css variable name from metadata extracted as it is used in the devtools Do not fail on third party css scripts Do not create variable for css var details
c9a0c94
to
3b0f3f8
Compare
vscaiceanu-1a
previously approved these changes
Jul 15, 2024
fpaul-1A
reviewed
Jul 15, 2024
packages/@o3r/styling/src/devkit/styling-devtools.message.service.ts
Outdated
Show resolved
Hide resolved
fpaul-1A
previously approved these changes
Jul 15, 2024
…ice.ts Co-authored-by: Florian PAUL <110407799+fpaul-1A@users.noreply.github.com>
kpanot
previously approved these changes
Jul 16, 2024
packages/@o3r/styling/src/devkit/styling-devtools.message.service.ts
Outdated
Show resolved
Hide resolved
…ice.ts Co-authored-by: Kilian Panot <kilian.panot@amadeus.com>
fpaul-1A
approved these changes
Jul 16, 2024
vscaiceanu-1a
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Do not remove css variable name from metadata extracted as it is used in the devtools
Do not fail on third party css scripts
Do not create variable for css var details