fix(localization): do not declare pipes that override another one #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a5b7754. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
github-actions
bot
added
bug
fpaul-1A
previously approved these changes
Jul 24, 2024
matthieu-crouzet
force-pushed
the
fix/1960
branch
from
53dd486
to
a5b7754
Compare
kpanot
approved these changes
Jul 24, 2024
kpanot
reviewed
Jul 24, 2024
| declarations: [TranslatePipeMock], | ||
| exports: [TranslatePipeMock] | ||
| }) | ||
| @NgModule() |
There was a problem hiding this comment.
On this version of Angular (pre-module compilation) was it possible to declare a pipe coming from a built library?
If not you may need to provide an additional module declaring these removed pipes
There was a problem hiding this comment.
In fact outside the module you will have the pipe from the common module and not the overrided one without the export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Do not declare pipes that override another one
Else we have 2 declaration of pipes with the same name and it causes
NG0313Related issues
datewhile using a date + translate pipe in a component for the unit tests #1960