chore: rework on Nx Cache and Doc #2338
Conversation
github-actions
bot
added
documentation
kpanot
force-pushed
the
chore/nx-cache
branch
from
26481c3
to
f400349
Compare
kpanot
force-pushed
the
chore/nx-cache
branch
3 times, most recently
from
ce32411
to
48f4b15
Compare
github-actions
bot
added
bug
| When building (`yarn build`) the project on `main` (or other `release/*`) branch, the Remote Cache will be downloaded. | ||
|
|
||
| > [!IMPORTANT] | ||
| > This feature is available for `@amadeus.com` email addresses, Nx Cloud Account should be created with a `@amadeus.com` email or it should be set as **main email** on Github if the Github account is used to register to Nx Cloud. |
There was a problem hiding this comment.
Isn't it a bit weird to document something this specific in this repository?
There was a problem hiding this comment.
That is an actual restriction, I think it is better to indicate it rather than hiding it.
But I am open if you think we should hide it.
There was a problem hiding this comment.
"if the Github account is used to register to Nx Cloud." I'm not sure I understand what that part means
There was a problem hiding this comment.
When you follow the link in the doc, you get
The message means : use the "Continue with Github" button to register to Nx Cloud
| "@angular-devkit/schematics-cli": "^18.0.5", | ||
| "@angular/cli": "~18.2.0", | ||
| "@o3r/schematics": "workspace:^", | ||
| "@openapitools/openapi-generator-cli": "~2.14.0", | ||
| "@schematics/angular": "~18.2.0" | ||
| "@schematics/angular": "~18.2.0", | ||
| "openapi-types": "^12.0.0", |
There was a problem hiding this comment.
Do we need this for the nx refacto?
There was a problem hiding this comment.
The question is valid for all the package dependency addition / updates
There was a problem hiding this comment.
As explained, these are missing optional peer dependencies detected by Nx since the refactor.
The fact that they have not been detected before is suspicious :S
kpanot
force-pushed
the
chore/nx-cache
branch
3 times, most recently
from
e9f88f4
to
2a57064
Compare
kpanot
force-pushed
the
chore/nx-cache
branch
4 times, most recently
from
6f898c8
to
e081f58
Compare
kpanot
force-pushed
the
chore/nx-cache
branch
from
e081f58
to
150639c
Compare
| @@ -25,6 +25,7 @@ | |||
| "@actions/github": "^6.0.0", | |||
| "@angular-devkit/build-angular": "~18.2.0", | |||
| "@angular-devkit/core": "~18.2.0", | |||
| "@angular-devkit/schematics": "~18.2.0", | |||
There was a problem hiding this comment.
Why is it needed ?
It's a GH app without any deps on Angular.
Same remark for the others @angular-devkit/* and @angular/*
For @angular-eslint/* we can discuss (for the eslint migration) if we keep these rules or not when the package does not depends on @angular/core
There was a problem hiding this comment.
They are need from Nx point of view for the following reasons:
- They are imported (even with
import type) - They are part of exported file (even builders are exported)
import type dependencies should be provided in case the skipLibCheck: false (which enforce the provide of type dependencies) but as it is not runtime dependencies, they can be flagged as optional
| "openapi-types": { | ||
| "optional": true | ||
| }, | ||
| "type-fest": { |
There was a problem hiding this comment.
isn't type-fest used only for jest test and so be only in devDep ?
There was a problem hiding this comment.
Same comment for this addition in other package
There was a problem hiding this comment.
Nop, it is used to exported Schematics and in CLIs
| "rxjs": "^7.8.1", | ||
| "sass": "~1.80.0", | ||
| "semver": "^7.5.2" | ||
| "semver": "^7.5.2", | ||
| "typescript": "~5.5.4" |
There was a problem hiding this comment.
Shouldn't typescript be only a devDep ?
There was a problem hiding this comment.
same remark for other packages that have this addition
There was a problem hiding this comment.
It is used in exported builders :S
doc: add documentation regarding Nx PAT new process
kpanot
force-pushed
the
chore/nx-cache
branch
from
150639c
to
a2e3c18
Compare
Proposed change
Rework on Nx Cache for clarification and simplification
Add documentation regarding Nx PAT new process