lock_api: Mark unlock and friends unsafe. #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes #242. |
Amanieu
reviewed
Jun 11, 2020
|
@brain0 Are you still working on this? Could you please address my review comments so that I can merge this. |
|
Yes, sorry, I'll take care of it |
|
There is a new conflict, would you prefer this to be solved via merge or rebase? |
|
I solved the conflict with a merge to simplify review. If you prefer I rebase it, I can still do that. |
|
A rebase is usually the preferred way to resolve conflicts. |
added 5 commits
June 17, 2020 23:07
Unlocking a Mutex that you do not hold is likely to cause undefined behavior. If unlock() is a safe method, then it likely impossible to provide a sound and efficient implemention of the method. Since this API is usually only called by the lock_api Mutex structs, this change should be invisible to the users, but clarifies what guarantees implementers must make.
…k is being held unsafe.
Okay, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods like
unlock,bump,upgrade,downgradeand similar all assume that a certain kind of lock is being held. Since the wrapper mutex and guard types in thelock_apicrate guarantee that these APIs are always used correctly, these methods are made unsafe to allow implementers to skip checks for these conditions. This allows sound and efficient implementations of these traits.I hope I did not forget any methods or screw up any comments.