Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lock_api: Mark unlock and friends unsafe. #243

Merged
merged 5 commits into from
Jun 18, 2020
Merged

lock_api: Mark unlock and friends unsafe. #243

merged 5 commits into from
Jun 18, 2020

Commits on Jun 17, 2020

  1. lock_api: Make RawMutex::unlock() unsafe. 

    Unlocking a Mutex that you do not hold is likely to cause undefined behavior. If unlock()
is a safe method, then it likely impossible to provide a sound and efficient implemention
of the method. Since this API is usually only called by the lock_api Mutex structs, this
change should be invisible to the users, but clarifies what guarantees implementers must make.
    Thomas Bächler committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    14e28ca View commit details
    Browse the repository at this point in the history

  2. lock_api: Make RawMutexFair::unlock_fair() and RawMutexFair::bump() u… 

    …nsafe.
    Thomas Bächler committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    4015183 View commit details
    Browse the repository at this point in the history

  3. lock_api: Make all methods of the RawRwLock* traits that assume a loc… 

    …k is being held unsafe.
    Thomas Bächler committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    1445550 View commit details
    Browse the repository at this point in the history

  4. Fix doc tests.

    Thomas Bächler committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    b27fc51 View commit details
    Browse the repository at this point in the history

  5. Fix incorrect doc comments.

    Thomas Bächler committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    1347de0 View commit details
    Browse the repository at this point in the history