Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 5 unhealthy rejected state with tests #17

Merged
merged 13 commits into from
May 18, 2020
Merged

Issue 5 unhealthy rejected state with tests #17

merged 13 commits into from
May 18, 2020

Conversation

simzzz
Copy link
Contributor

@simzzz simzzz commented May 4, 2020

No description provided.

@simzzz simzzz requested a review from elpiel May 4, 2020 17:32
simzzz
simzzz commented May 4, 2020
View reviewed changes
src/status.rs Outdated Show resolved Hide resolved
elpiel
elpiel requested changes May 5, 2020
View reviewed changes
src/status.rs Outdated Show resolved Hide resolved
src/status.rs Outdated Show resolved Hide resolved
src/status.rs Outdated Show resolved Hide resolved
src/status.rs Outdated Show resolved Hide resolved
src/status_test.rs Outdated Show resolved Hide resolved
elpiel
elpiel requested changes May 7, 2020
View reviewed changes
src/sentry_api.rs Outdated Show resolved Hide resolved
src/status.rs Outdated Show resolved Hide resolved
elpiel
elpiel requested changes May 11, 2020
View reviewed changes
Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also see that the is_rejected_state test still need fixing (because we pass SentryApi and query it inside).

src/status.rs Outdated Show resolved Hide resolved
src/status_test.rs Show resolved Hide resolved
src/status.rs Outdated Show resolved Hide resolved
@elpiel elpiel merged commit f399347 into master May 18, 2020
@elpiel elpiel deleted the issue-5-unhealthy-rejected-state-with-tests branch May 19, 2020 09:06
@elpiel elpiel mentioned this pull request May 22, 2020
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpiel elpiel elpiel requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simzzz @elpiel