Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 5 health function #6

Merged
merged 19 commits into from
Apr 14, 2020
Merged

Issue 5 health function #6

merged 19 commits into from
Apr 14, 2020

Conversation

elpiel
Copy link
Member

@elpiel elpiel commented Apr 7, 2020

Part of #5

  • is_finalized()
  • get_status (needs testing)
  • is_offline (needs testing)
  • Cache::finalize_campaign
  • bugfix Cache::initialize
  • SentryApi::get_last_approved
  • httptest setup

@elpiel elpiel mentioned this pull request Apr 7, 2020
14 tasks
@elpiel elpiel marked this pull request as ready for review April 7, 2020 16:36
@elpiel elpiel requested a review from simzzz April 8, 2020 08:21
Copy link
Contributor

@simzzz simzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will test thoroughly when I implement the next few functions.

@elpiel elpiel force-pushed the issue-5-health-function branch from af4efbc to 8ff65e5 Compare April 13, 2020 08:51
@elpiel
Copy link
Member Author

elpiel commented Apr 14, 2020

I am merging this one as it became too big, I will add tasks to #5 to account for the missing tests, etc.

@elpiel elpiel merged commit 362e091 into master Apr 14, 2020
@elpiel elpiel mentioned this pull request Apr 14, 2020
3 tasks
@elpiel elpiel deleted the issue-5-health-function branch April 24, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants