isDateRecent(), isDisconnected(), isInitializing() #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simzzz
commented
Apr 13, 2020
simzzz
commented
Apr 13, 2020
elpiel
requested changes
Apr 13, 2020
elpiel
reviewed
Apr 13, 2020
elpiel
requested changes
Apr 16, 2020
simzzz
changed the title
elpiel
requested changes
Apr 22, 2020
| let messages = Messages { | ||
| leader: LastApprovedResponse { | ||
| last_approved: Some(LastApproved { | ||
| new_state: Some(new_state), |
There was a problem hiding this comment.
Is this the same test from the Market?
https://github.com/AdExNetwork/adex-market/blob/master/test/validatorTestMessages.js#L165
If so, they are a bit different, maybe you can elaborate on that?
There was a problem hiding this comment.
Yes, the initializing state is when there are no messages at all for at least one validator. This is the case where both validators have messages therefore it's false. The difference is that here there is also a newState and an approveState. I will add another with only heartbeats (both should be false)
elpiel
reviewed
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.