Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create example for the RGB LED on the BW16 #217

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Create example for the RGB LED on the BW16 #217

merged 3 commits into from
Feb 15, 2024

Conversation

designer2k2
Copy link
Contributor

Description of Change

Example on how to Blink and Fade the RGB LED on the BW16.

It is a simple sketch showing what can be done with the RGB LED.

Tests and Environments

Tested on a BW16-TypeC with Arduino IDE 2.3.0 in Windows 10.

@designer2k2
Create example for the RGB LED on the BW16
d53c5d8 
Example on how to Blink and Fade the RGB LED on the BW16
github-actions[bot]
github-actions bot reviewed Feb 9, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, hope this message finds you well. Congrats to your Pull Request! Thank you for the work. Your contributions have been outstanding

M-ichae-l
M-ichae-l requested changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@M-ichae-l M-ichae-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the example is only for BW16,
Please add the marco BOARD_AITHINKER_BW16 to avoid compatibility problem
#ifdef BOARD_AITHINKER_BW16
#endif

@designer2k2
Update BW16_RGB_LED.ino with board check
72c793e 
check if the correct board is used
@designer2k2
Copy link
Contributor Author

Hello @M-ichae-l ,
i added the check and it will give a error during compilation now.

But one thing, BOARD_AITHINKER_BW16 does not work for me, i have to use BOARD_RTL8720DN_BW16?

@M-ichae-l
Copy link
Contributor

@designer2k2
For BW16 this the related marco
https://github.com/ambiot/ambd_arduino/blob/e8df7125f9f0701eea4e57cb6fa07526cd1ced72/Arduino_package/hardware/boards.txt#L111

Refer to early release V3.1.7

M-ichae-l
M-ichae-l requested changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@M-ichae-l M-ichae-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 12 needs to update.

@designer2k2
Update BW16_RGB_LED.ino with correct macro
9bb010c 
change from BOARD_RTL8720DN_BW16 to BOARD_AITHINKER_BW16.
@M-ichae-l M-ichae-l merged commit b9890b7 into Ameba-AIoT:dev Feb 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@M-ichae-l M-ichae-l M-ichae-l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@designer2k2 @M-ichae-l