Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added private function __search_expand_command_path() #193

Merged
merged 4 commits into from
Jun 29, 2024
Merged

Added private function __search_expand_command_path() #193

merged 4 commits into from
Jun 29, 2024

Conversation

elfpipe
Copy link
Collaborator

@elfpipe elfpipe commented Jun 27, 2024

Work-in-progress suggestion for an added cli path search for the unix-amiga path translation utility functions.

Copy link
Collaborator

@afxgroup afxgroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please:

  1. Remove changes from GNUMakefile.os4
  2. Use __USE_INLINE__ in search_command_path.c file since all library (except for shared library initalization) is not using interfaces
  3. in translateu2a.c remove commented function and please reformat code to follow the code
  4. in unistd_headers.h there is now an extern struct UtilityIFace *__IUtility that is not needed

@elfpipe
Copy link
Collaborator Author

elfpipe commented Jun 27, 2024

How do I access IUtility, if I can not refer to __IUtility?
Do I have privileges to call OpenLibrary()/GetInterface()? Or is there a different solution?

@afxgroup
Copy link
Collaborator

Add:

DECLARE_UTILITYBASE();

In your code. Search for DECLARE_UTILITYBASE(); to see how it is used

@elfpipe
Copy link
Collaborator Author

elfpipe commented Jun 27, 2024

@afxgroup : 3. In translateu2a.c remove commented function and please reformat code to follow the code

I am guessing, you mean the call to __translate_relative_path_name...?

I think, it should still be there, since it could still be relevant after a cmd path search. What do you think?

@afxgroup
Copy link
Collaborator

I'm speaking about code writing convention. Meaning formatting code. for example if(a) is wrong. If (a) is correct. LiteXl should have a formatter

@afxgroup afxgroup merged commit 64bec46 into AmigaLabs:beta10 Jun 29, 2024
@elfpipe
Copy link
Collaborator Author

elfpipe commented Jun 29, 2024

I added formatter_clangformat.lua to the lite-xl plugins. The plugin is activated on keycombo (it writes a message), but the command does nothing. From looking at the lua, it seems, that it is not really implemented. I guess that is another vacation project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants