Refactor comments.

internal/nonce/nonce.go

@@ -9,24 +9,27 @@ import (
 	"github.com/Amnesic-Systems/veil/internal/errs"
 )
 
-const Len = 20 // The length of a nonce in bytes.
+// Len is the length of a nonce in bytes.
+const Len = 20
 
 var (
 	// Accessing rand.Reader via variable facilitates mocking.
 	cryptoRead       = rand.Reader
 	errNotEnoughRead = errors.New("failed to read enough random bytes")
 )
 
+// Nonce is a random value that guarantees attestation document freshness.
 type Nonce [Len]byte
 
+// URLEncode returns the nonce as a URL-encoded string.
 func (n *Nonce) URLEncode() string {
 	return url.QueryEscape(
 		base64.StdEncoding.EncodeToString(n[:]),
 	)
 }
 
+// New creates a new nonce.
 func New() (*Nonce, error) {
-	// TODO: panic on error cause we may not be able to recover?
 	var newNonce Nonce
 	n, err := cryptoRead.Read(newNonce[:])
 	if err != nil {
@@ -38,6 +41,7 @@ func New() (*Nonce, error) {
 	return &newNonce, nil
 }
 
+// FromSlice turns a byte slice into a nonce.
 func FromSlice(s []byte) (*Nonce, error) {
 	if len(s) != Len {
 		return nil, errs.InvalidLength

internal/service/attestation/aux.go

@@ -1,7 +1,5 @@
 package attestation
 
-// TODO: does this belong in the enclave package?
-
 import (
 	"slices"
 

internal/service/attestation/hashes.go

@@ -14,8 +14,6 @@ import (
 // the enclave's attestation document for clients to verify.
 type Hashes struct {
 	sync.Mutex
-	// TODO: is this better off in models? model.AttestationHashes sounds less
-	// nice though
 	TlsKeyHash [sha256.Size]byte `json:"tls_key_hash"` // Always set.
 	AppKeyHash [sha256.Size]byte `json:"app_key_hash"` // Only set if the application has keys.
 }