Reintegrate dev/v0.10 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbsPlainT3Unit -> AbsT4Unit AbsReviewT3Unit -> AbsT3Unit
PyTorch stable does not support 3.12 yet See: pytorch/pytorch#110436
AmpelBaseModel subclasses can't set extra attributes by default.
Since this will always be mixed into the inheritance chain of AmpelUnit or BaseModel, both of which harvest annotations from their bases, there's not actually a reason for this to be a BaseModel itself.
Ideally there would be a declared result type, such that downstream consumers can be type checked
for python<3.12 compatibility. typing.TypedDict lacks necessary metadata before python 3.12; see https://docs.pydantic.dev/2.3/usage/types/dicts_mapping/#typeddict
now compatible with both PEP517 _and_ scipy 1.14
good riddance, i say
jvansanten
force-pushed
the
dev/v0.10
branch
2 times, most recently
from
b2007cc to
582616b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.