Moved SelectionBox and SelectionGroup to C++ #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The visual studio project is now created like the folder structure
The new constructor accepts any iterable python object
The selection box class now stores the minimum point and the size. The selection box does not store the order the points were given at construction. This simplifies the class a bit.
This adds on the needed __eq__ type hint to make mypy happy. pybind11 behaves like this but does not generate the docstring.
This is now handled in the stub generator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved build tools.
Improved stub generator.
Removed custom
__eq__handling. This is now handled in the stub generator.