Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PKG-4701 initial v12.4 #1

Merged
merged 3 commits into from
May 16, 2024
Merged

PKG-4701 initial v12.4 #1

merged 3 commits into from
May 16, 2024

Conversation

danpetry
Copy link

@danpetry danpetry commented May 10, 2024 •
edited
Loading

Destination channel: defaults

Links

Explanation of changes:

  • Part of CUDA 12.4 build, following conda-forge's pattern which was developed in conjunction with Nvidia. I don't see a need to stage these then release them all at once. They won't cause a problem released one at a time.
  • Please check the main branch too, this has just been forked
  • Changes made to adjust feedstocks for differences between conda-forge and defaults. Please see commit messages for description of changes.

@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_d9fpn3jezd/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:0: no_global_test: Global tests are ignored in multi-output recipes.
  • clone/recipe/meta.yaml:106: license_file_overspecified: Using license_file and license_url is overspecified.
  • clone/recipe/meta.yaml:46: host_section_needs_exact_pinnings: output "cuda-opencl": Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:46: host_section_needs_exact_pinnings: output "cuda-opencl": Linked libraries host should have exact version pinnings.

===== ERRORS =====

  • clone/recipe/meta.yaml:34: outputs_not_unique: output "cuda-opencl": Output name is not unique
  • clone/recipe/meta.yaml:106: missing_dev_url: The recipe is missing a dev_url
  • clone/recipe/meta.yaml:106: missing_license_family: The recipe is missing the about/license_family key.
  • clone/recipe/meta.yaml:1: missing_tests: output "cuda-opencl": No tests were found.
    ===== Final Report: =====
    4 Errors and 4 Warnings were found

@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_338y_wmafw/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:106: license_file_overspecified: Using license_file and license_url is overspecified.
  • clone/recipe/meta.yaml:0: no_global_test: Global tests are ignored in multi-output recipes.

===== ERRORS =====

  • clone/recipe/meta.yaml:34: outputs_not_unique: output "cuda-opencl": Output name is not unique
  • clone/recipe/meta.yaml:106: missing_license_family: The recipe is missing the about/license_family key.
  • clone/recipe/meta.yaml:1: missing_tests: output "cuda-opencl": No tests were found.
  • clone/recipe/meta.yaml:106: missing_dev_url: The recipe is missing a dev_url
    ===== Final Report: =====
    4 Errors and 2 Warnings were found

@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_82ciqtae1e/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:106: license_file_overspecified: Using license_file and license_url is overspecified.
  • clone/recipe/meta.yaml:0: no_global_test: Global tests are ignored in multi-output recipes.

===== ERRORS =====

  • clone/recipe/meta.yaml:106: missing_dev_url: The recipe is missing a dev_url
  • clone/recipe/meta.yaml:1: missing_tests: output "cuda-opencl": No tests were found.
  • clone/recipe/meta.yaml:34: outputs_not_unique: output "cuda-opencl": Output name is not unique
  • clone/recipe/meta.yaml:106: missing_license_family: The recipe is missing the about/license_family key.
    ===== Final Report: =====
    4 Errors and 2 Warnings were found

@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_8ez3aljxry/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:106: license_file_overspecified: Using license_file and license_url is overspecified.
  • clone/recipe/meta.yaml:0: no_global_test: Global tests are ignored in multi-output recipes.

===== ERRORS =====

  • clone/recipe/meta.yaml:106: missing_dev_url: The recipe is missing a dev_url
  • clone/recipe/meta.yaml:106: missing_license_family: The recipe is missing the about/license_family key.
  • clone/recipe/meta.yaml:34: outputs_not_unique: output "cuda-opencl": Output name is not unique
  • clone/recipe/meta.yaml:1: missing_tests: output "cuda-opencl": No tests were found.
    ===== Final Report: =====
    4 Errors and 2 Warnings were found

cbouss
cbouss reviewed May 13, 2024
View reviewed changes
Copy link

@cbouss cbouss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it work without an ocl loader?
I see this one too: https://github.com/conda-forge/ocl-icd-system-feedstock/tree/main
Which seems to indicate having a system ocl would work out of the box.
Is that package (cuda-opencl) needed for other tasks?

@danpetry
Copy link
Author

The loader's a broker between different OpenCL implementations and your application. It's needed if there are multiple opencl implementations on the system. Which is a common occurrence AFAIU. It's possible to build applications that link directly to the OpenCL implementation but then it will only work with that one which seems to defeat the purpose (it's supposed to allow portability between different hardware architectures). Having said that, cuda-opencl is called by the ICD loader, not the other way around. So I'm not sure if it's accurate to express the ICD loader as a dependency of cuda-opencl, rather should be up to the user to manage this aspect. Even though in practical scenarios it's needed.

@danpetry
Copy link
Author

danpetry commented May 13, 2024 •
edited
Loading

This package isn't used anywhere else apart from being grouped in the cuda-libraries metapackage.

I can see why conda-forge added the loader. I'm open as to whether we should. It doesn't look too difficult.

@JeanChristopheMorinPerso
Copy link

@danpetry DO you have a link to some documentation that could help us understand what's at play? I'm not verry familiar with all of this (read I have zero knowledge).

@danpetry
Copy link
Author

danpetry commented May 13, 2024 •
edited
Loading

https://www.khronos.org/news/permalink/opencl-installable-client-driver-icd-loader

@danpetry
Copy link
Author

I'll address the dependencies and come back to this discussion if it's looking like a headache for some reason

skupr-anaconda
skupr-anaconda reviewed May 15, 2024
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
@danpetry
Correct upstream's bld.bat
790cce3 
- the "if" from "if not exist" wasn't present, resulting in a script failure
- the files in the include\ directory weren't being moved because windows
  doesn't move recursively by default
@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_7de4zy8whg/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:46: host_section_needs_exact_pinnings: output "cuda-opencl": Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:0: no_global_test: Global tests are ignored in multi-output recipes.
  • clone/recipe/meta.yaml:46: host_section_needs_exact_pinnings: output "cuda-opencl": Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:106: license_file_overspecified: Using license_file and license_url is overspecified.

===== ERRORS =====

  • clone/recipe/meta.yaml:34: outputs_not_unique: output "cuda-opencl": Output name is not unique
  • clone/recipe/meta.yaml:1: missing_tests: output "cuda-opencl": No tests were found.
  • clone/recipe/meta.yaml:106: missing_license_family: The recipe is missing the about/license_family key.
  • clone/recipe/meta.yaml:106: missing_dev_url: The recipe is missing a dev_url
    ===== Final Report: =====
    4 Errors and 4 Warnings were found

@danpetry @skupr-anaconda
Make platform selector more readable
74c5676 
Co-authored-by: skupr-anaconda <79282962+skupr-anaconda@users.noreply.github.com>
@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_d3y63993_4/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:106: license_file_overspecified: Using license_file and license_url is overspecified.
  • clone/recipe/meta.yaml:46: host_section_needs_exact_pinnings: output "cuda-opencl": Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:46: host_section_needs_exact_pinnings: output "cuda-opencl": Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:0: no_global_test: Global tests are ignored in multi-output recipes.

===== ERRORS =====

  • clone/recipe/meta.yaml:1: missing_tests: output "cuda-opencl": No tests were found.
  • clone/recipe/meta.yaml:106: missing_dev_url: The recipe is missing a dev_url
  • clone/recipe/meta.yaml:106: missing_license_family: The recipe is missing the about/license_family key.
  • clone/recipe/meta.yaml:34: outputs_not_unique: output "cuda-opencl": Output name is not unique
    ===== Final Report: =====
    4 Errors and 4 Warnings were found

@danpetry danpetry merged commit 8a8b3bc into main May 16, 2024
7 of 8 checks passed
@danpetry danpetry deleted the PKG-4701-12.4-initial branch May 16, 2024 20:49
@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_5bn5j_mkze/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:0: no_global_test: Global tests are ignored in multi-output recipes.
  • clone/recipe/meta.yaml:106: license_file_overspecified: Using license_file and license_url is overspecified.
  • clone/recipe/meta.yaml:46: host_section_needs_exact_pinnings: output "cuda-opencl": Linked libraries host should have exact version pinnings.
  • clone/recipe/meta.yaml:46: host_section_needs_exact_pinnings: output "cuda-opencl": Linked libraries host should have exact version pinnings.

===== ERRORS =====

  • clone/recipe/meta.yaml:106: missing_dev_url: The recipe is missing a dev_url
  • clone/recipe/meta.yaml:106: missing_license_family: The recipe is missing the about/license_family key.
  • clone/recipe/meta.yaml:34: outputs_not_unique: output "cuda-opencl": Output name is not unique
  • clone/recipe/meta.yaml:1: missing_tests: output "cuda-opencl": No tests were found.
    ===== Final Report: =====
    4 Errors and 4 Warnings were found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skupr-anaconda skupr-anaconda skupr-anaconda left review comments

@psteyer psteyer psteyer approved these changes

@cbouss cbouss cbouss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@danpetry @anaconda-pkg-build @JeanChristopheMorinPerso @cbouss @psteyer @skupr-anaconda