Skip to content

Commit

Permalink
Use conda ar rather than system one
Browse files Browse the repository at this point in the history
  • Loading branch information
danpetry committed May 16, 2024
1 parent 3269d16 commit c4c66c7
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 0 deletions.
16 changes: 16 additions & 0 deletions recipe/0002-use-conda-ar-not-system.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
This fixes an issue where the build fails on linux-aarch64, because a system ar
can't be found. Presumably it's using the system ar on other platforms, too,
which isn't ideal.
Index: nccl/src/Makefile
===================================================================
--- nccl.orig/src/Makefile 2024-05-16 16:58:16.522514975 -0500
+++ nccl/src/Makefile 2024-05-16 17:47:45.959416166 -0500
@@ -83,7 +83,7 @@
$(LIBDIR)/$(STATICLIBTARGET): $(LIBOBJ) $(DEVMANIFEST)
@printf "Archiving %-35s > %s\n" $(STATICLIBTARGET) $@
mkdir -p $(LIBDIR)
- ar cr $@ $(LIBOBJ) $$(cat $(DEVMANIFEST))
+ $(AR) cr $@ $(LIBOBJ) $$(cat $(DEVMANIFEST))

$(PKGDIR)/nccl.pc : nccl.pc.in
mkdir -p $(PKGDIR)
2 changes: 2 additions & 0 deletions recipe/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ source:
patches:
# This isn't needed; setting CUDA_HOME sets NVCC correctly
#- 0001-Allow-custom-NVCC-path.patch
- 0002-use-conda-ar-not-system.patch

build:
number: 0
Expand All @@ -28,6 +29,7 @@ requirements:
- {{ compiler("cxx") }}
- {{ compiler("cuda") }}
- make
- patch
host:
- cuda-version ={{ cuda_compiler_version }} # [(cuda_compiler_version or "").startswith("11")]
run:
Expand Down

0 comments on commit c4c66c7

Please sign in to comment.