Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs 20.17.0 #20

Merged
merged 8 commits into from
Sep 9, 2024
Merged

nodejs 20.17.0 #20

merged 8 commits into from
Sep 9, 2024

Conversation

skupr-anaconda
Copy link

@skupr-anaconda skupr-anaconda commented Sep 5, 2024

Destination channel: main

Links

Explanation of changes:

  • Use -j${CPU_COUNT} on Unix platforms
  • Add libuv to build as it's a bootstrap dependency in js2c starting with 20.3, see tools: port js2c.py to C++ nodejs/node#46997
  • Use libuv 1.48 in host because of new uv_pipe_bind2 and uv_pipe_connect2 methods

Notes:

  • jupyterlab 4.2.5 requires nodejs >=20,<21 at runtime

@skupr-anaconda skupr-anaconda self-assigned this Sep 5, 2024
@skupr-anaconda skupr-anaconda marked this pull request as ready for review September 5, 2024 13:32
recipe/conda_build_config.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated
@@ -1,7 +1,7 @@
{% set version = "18.18.2" %}
{% set version = "20.9.0" %}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest 20 version is 20.17.0: https://github.com/nodejs/node/tree/v20.17.0

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Author

@skupr-anaconda skupr-anaconda Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added adjustments to solve nodejs/node#52223.
And updated the install.py command as $PYTHON tools/install.py install --dest-dir ${PREFIX} --prefix ''

Copy link

@cbouss cbouss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skupr-anaconda skupr-anaconda merged commit 99beb53 into master Sep 9, 2024
8 checks passed
@skupr-anaconda skupr-anaconda deleted the nodejs_20.9.0 branch September 9, 2024 06:47
@skupr-anaconda skupr-anaconda changed the title nodejs 20.9.0 nodejs 20.17.0 Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants