V1.76 #7
V1.76 #7
Conversation
There was a problem hiding this comment.
The PR looks okay. From the release note, I am not sure whether we are affected by this point: rust-lang/rust#117947
Have you tried building packages with it? What is the outcome?
|
I agree, for compilers it's useful to build some other packages with them to validate them. the testing in the feedstocks here is quite basic too, you might want to include some of the tests from conda-forge's feedstock |
|
@danpetry Let me know if this is more along the lines of what you were thinking. |
I think so. That you have the option to build rust from source and use your own llvm. So it shouldn't affect us. But it's still good to verify the compiler is actually working. |
| - /usr/lib/libc++.1.dylib | ||
| - /usr/lib/libc++abi.dylib | ||
| - /usr/lib/libiconv.2.dylib | ||
| - /usr/lib/libcurl.4.dylib |
There was a problem hiding this comment.
curl is needed on unix, see https://github.com/rust-lang/rust/blob/master/INSTALL.md#dependencies
Should we add it to host?
There was a problem hiding this comment.
The build is installing but not actually building, so we are fine here.
| - /usr/lib/libresolv.9.dylib | ||
| - /usr/lib/libc++.1.dylib | ||
| - /usr/lib/libc++abi.dylib | ||
| - /usr/lib/libiconv.2.dylib |
There was a problem hiding this comment.
libiconv is required on linux but here is only osx. Hmm https://github.com/rust-lang/rust/blob/master/INSTALL.md#dependencies
| - /System/Library/Frameworks/Python.framework/Versions/2.7/Python | ||
| - /System/Library/PrivateFrameworks/DebugSymbols.framework/Versions/A/DebugSymbols | ||
| - /usr/lib/libcompression.dylib | ||
| - /usr/lib/libedit.3.dylib | ||
| - /usr/lib/libform.5.4.dylib | ||
| - /usr/lib/libncurses.5.4.dylib | ||
| - /usr/lib/libpanel.5.4.dylib | ||
| - /usr/lib/libxml2.2.dylib |
There was a problem hiding this comment.
Should all .dylib have the selector # [osx]?
There was a problem hiding this comment.
we could, but that won't change the end result
| - '**/ld-linux-x86-64.so.2' | ||
| - '**/libc.so.6' | ||
| - '**/libdl.so.2' | ||
| - '**/ld64.so.*' |
There was a problem hiding this comment.
Is this a known defect of s390x only like $RPATH/ld64.so.1?
|
As noted above, I'd like to see some stuff compiled with this, in conjunction with the activation feedstock ideally |
| requirements: | ||
| build: | ||
| - {{ compiler('c') }} # [osx] | ||
| - posix # [win] | ||
| test: | ||
| requires: | ||
| - {{ compiler('c') }} |
There was a problem hiding this comment.
what is a c compiler necessary for?
There was a problem hiding this comment.
To run forge_test.sh, a backend compiler is required.
Usually this is brought in by the activation feedstock, but here we are one step early, so we need to include it in test/requires.
rust 1.76.0
Destination channel: defaults
Links
Explanation of changes:
sha256osx-64to 10.12missing_dsorelocated due toconda-buildhandling