Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TLS and HTTP 2.0 websocket connection #151

Closed
4 tasks
Lohann opened this issue Jul 28, 2023 · 0 comments · Fixed by #153
Closed
4 tasks

Support TLS and HTTP 2.0 websocket connection #151

Lohann opened this issue Jul 28, 2023 · 0 comments · Fixed by #153
Assignees
Labels
bug Something isn't working enhancement New feature or request priority: high

Comments

@Lohann
Copy link
Collaborator

Lohann commented Jul 28, 2023

Feature description
Currently subtx uses jsonrpcsee that uses soketto as websocket client, the issue is that Soketto only supports HTTP 1.1 connections, which prevents it from connecting to public RPC urls such as wss://rpc.astar.network:443.

jsonrpcsee was designed to be a safe json-rpc server for substrate, not a client.

Possible Solution

Subtx allow different clients, it just need to implement the RpcClientT trait, it is implemented for jsonrpcsee here, we can implement that same trait for another client like tokio-tungstenite which supports TLS and HTTP 2.0.

Expected output

  • astar connector can to connect to any public or local RPC node
  • polkadot connector can to connect to any public or local RPC node
  • if https://dotapps.io can to connect to it, we must be able to connect too!
  • Create unit tests using self-signed certificates for testing the TLS connection.
@Lohann Lohann added bug Something isn't working enhancement New feature or request labels Jul 28, 2023
@Lohann Lohann self-assigned this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request priority: high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant