Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-151 and 149: Support Subxt wss connections #153

Merged
merged 11 commits into from
Aug 7, 2023

Conversation

Lohann
Copy link
Collaborator

@Lohann Lohann commented Jul 29, 2023

Description

Supports WSS connections in subxt
Fixes #151 and #149

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Code review prechecks:

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Inline comments have been added for each method
  • I have made corresponding changes to the documentation
  • Code changes introduces no new problems or warnings
  • Test cases have been added
  • Dependent changes have been merged and published in downstream modules

@Lohann Lohann changed the title WIP Support Subtx wss connections WIP Support Subxt wss connections Jul 29, 2023
@Lohann Lohann changed the title WIP Support Subxt wss connections ISSUE-151: Support Subxt wss connections (WIP) Jul 29, 2023
@Lohann Lohann changed the title ISSUE-151: Support Subxt wss connections (WIP) ISSUE-151 and 149: Support Subxt wss connections Aug 4, 2023
@Lohann Lohann marked this pull request as ready for review August 4, 2023 20:45
@Lohann Lohann requested a review from dvc94ch August 4, 2023 20:45
parity-scale-codec = "3.4.0"
rosetta-config-astar = { version = "0.4.0", path = "../config" }
rosetta-config-ethereum = { version = "0.4.0", path = "../../ethereum/config" }
rosetta-server = { version = "0.4.0", path = "../../../rosetta-server" }
rosetta-server-ethereum = { version = "0.4.0", path = "../../ethereum/server" }
serde_json = "1.0.94"
serde_json = "1.0"
Copy link
Collaborator Author

@Lohann Lohann Aug 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the minor tag from a few crates because it allows cargo to solve and get the latest minor version, so we don't have to update it manually every time.

Copy link
Contributor

@dvc94ch dvc94ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

rosetta-server/Cargo.toml Outdated Show resolved Hide resolved
rosetta-server/src/ws.rs Outdated Show resolved Hide resolved
@Lohann Lohann merged commit 9b82a87 into master Aug 7, 2023
@dvc94ch dvc94ch deleted the bugfix/issue-151-support-wss-connections branch September 7, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support TLS and HTTP 2.0 websocket connection
2 participants