Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to block number param to Ethereum and Astar Connectors call method #159

Closed
1 task
Lohann opened this issue Aug 11, 2023 · 0 comments · Fixed by #161
Closed
1 task

Add to block number param to Ethereum and Astar Connectors call method #159

Lohann opened this issue Aug 11, 2023 · 0 comments · Fixed by #161
Assignees
@Lohann
Labels
priority: high

Comments

@Lohann
Copy link
Collaborator

Lohann commented Aug 11, 2023

Feature description
@Haider-Ali-DS requested a feature for supporting executing a call at a specific block on ethereum and astar connectors.

Expected output

  • The user can provide the block number as an optional parameter when executing call on astar en ethereum connectors.
@Lohann Lohann self-assigned this Aug 11, 2023
@Lohann Lohann mentioned this issue Aug 16, 2023
Merged
8 tasks
Lohann added a commit that referenced this issue Aug 17, 2023
@Lohann
#159 Support block-number and finality (#161)
5bb9244 
* Properly cleanup containers after each test

* Fix cargo-deny warnings

* Cleanup docker before running the tests

* Add block_number parameter to CallRequest

* replace match by Option::transpose

* Add finalized block to network/status

* Add documentation to bitcoin's confirmation period

* Cleanup docker before build connectors.

* Use PartialBlockIdentifier instead BlockIdentifier

* Fix clippy warnings

* Add block_id to storage as storage_proof calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lohann Lohann

Labels
priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#159 Support block-number and finality Analog-Labs/chain-connectors
2 participants
@Lohann @0x1100010010