Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eth storage proof #102

Merged
merged 11 commits into from
Mar 2, 2023
Merged

Eth storage proof #102

merged 11 commits into from
Mar 2, 2023

Conversation

Haider-Ali-DS
Copy link
Contributor

Description

  • Add Ethereum method send implementation.
  • Storage Proof implementation
  • List Transaction and find transaction test cases added
  • Code improvement

Fixes # (issue)
#76

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Tests

Describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • List Transactions
  • Find Transactions

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:

Code review prechecks:

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Inline comments have been added for each method
  • I have made corresponding changes to the documentation
  • Code changes introduces no new problems or warnings
  • Test cases have been added
  • Dependent changes have been merged and published in downstream modules

@Haider-Ali-DS Haider-Ali-DS mentioned this pull request Feb 28, 2023
Closed
8 tasks
@Haider-Ali-DS Haider-Ali-DS requested a review from dvc94ch March 1, 2023 11:57
dvc94ch
dvc94ch requested changes Mar 1, 2023
View reviewed changes
rosetta-server/src/lib.rs Show resolved Hide resolved
rosetta-server/src/indexer.rs Outdated Show resolved Hide resolved
rosetta-server/src/indexer.rs Outdated Show resolved Hide resolved
@dvc94ch
Copy link
Contributor

dvc94ch commented Mar 1, 2023

in general when there is a problem, there are different ways you can fix it. usually there is a right way, at the source, and not introducing buggy hacks all over the place, because this leads to complicated unmaintainable spaghetti code over time.

dvc94ch
dvc94ch reviewed Mar 2, 2023
View reviewed changes
chains/ethereum/server/src/utils.rs Outdated Show resolved Hide resolved
chains/ethereum/server/src/utils.rs Outdated Show resolved Hide resolved
@dvc94ch dvc94ch merged commit 207ee31 into master Mar 2, 2023
@dvc94ch dvc94ch deleted the eth-storage-proof branch March 2, 2023 16:54
@isabellelaususan isabellelaususan added this to the Milestone Q1 2023 milestone Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvc94ch dvc94ch dvc94ch requested changes

Assignees

@Haider-Ali-DS Haider-Ali-DS

Labels
None yet
Projects
None yet
Milestone
Milestone Q1 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@Haider-Ali-DS @dvc94ch @isabellelaususan