Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add astar config #152

Merged
merged 11 commits into from
Jul 29, 2023
Merged

Conversation

Lohann
Copy link
Collaborator

@Lohann Lohann commented Jul 29, 2023

Description

Adds Astar Config to Ethereum connector

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Code review prechecks:

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Inline comments have been added for each method
  • I have made corresponding changes to the documentation
  • Code changes introduces no new problems or warnings
  • Test cases have been added
  • Dependent changes have been merged and published in downstream modules

@Lohann Lohann requested review from dvc94ch and Haider-Ali-DS July 29, 2023 15:09
@Lohann Lohann self-assigned this Jul 29, 2023
Copy link
Contributor

@dvc94ch dvc94ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should also add a config for the Ethereum mainnet

Comment on lines +6 to +7
FROM alpine:latest AS certs
RUN apk --update add ca-certificates
Copy link
Collaborator Author

@Lohann Lohann Jul 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove this once we make sure that all crates are using webpki_rustls

chains/ethereum/config/src/lib.rs Outdated Show resolved Hide resolved
@Lohann Lohann merged commit 0e933b7 into master Jul 29, 2023
@dvc94ch dvc94ch deleted the hotfix/add-astar-config-to-ethereum-connector branch September 7, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants