Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup docker images after build #157

Merged
merged 10 commits into from
Aug 11, 2023
Merged

Conversation

Lohann
Copy link
Collaborator

@Lohann Lohann commented Aug 8, 2023

Description

When running ./build_connectors.sh many times, dangling images get accumulated locally, also because of the multi-stage build it now builds two images per connector. This PR fixes the script for properly cleanup the images after build.

References:

Changes

  • Automatically remove dangling images after each build
  • Properly set docker image labels, which wasn't working
  • Check docker image labels after each build
  • Display more useful information in the ./build_connectors.sh output
  • Fix ./reset_docker.sh script for skip docker builtin networks
  • Add Shellcheck on CI
  • Move all scripts to ./scripts folder

Type of change

  • New feature (non-breaking change which adds functionality)

Code review prechecks:

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Inline comments have been added for each method
  • I have made corresponding changes to the documentation
  • Code changes introduces no new problems or warnings
  • Test cases have been added
  • Dependent changes have been merged and published in downstream modules

@Lohann Lohann requested review from dvc94ch and penumbra23 August 8, 2023 03:34
Copy link
Contributor

@penumbra23 penumbra23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit!

@Lohann Lohann merged commit 5406668 into master Aug 11, 2023
@dvc94ch dvc94ch deleted the bugfix/properly-cleanup-docker-images branch September 7, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants