Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX: Upgrade go-ethereum version #165

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Conversation

Lohann
Copy link
Collaborator

@Lohann Lohann commented Aug 18, 2023

Description

ethereum/client-go:v1.10.2 doesn't support returning the finalized block, upgrading it to ethereum/client-go:v1.12.2 for fix /network/status endpoint on local environment.

Steps to Reproduce

Start a local node

docker run --rm -it -p 8545:8545 ethereum/client-go:v1.12.2 \
  --dev \
  --dev.period=2 \
  --ipcdisable \
  --http \
  --http.addr=0.0.0.0 \
  --http.port=8545 \
  --http.vhosts='*' \
  --http.api=eth,debug,admin,txpool,web3

Query the finalized block

curl -XPOST -H "Content-type: application/json" \
    -d '{"jsonrpc":"2.0","method":"eth_getBlockByNumber","params":["finalized", false], "id":1}' \
    'http://localhost:8545'

Using ethereum/client-go:v1.10.26 returns this:

{
    "jsonrpc": "2.0",
    "id": 1,
    "result": null
}

Using ethereum/client-go:v1.12.2 it works as expected:

{
    "jsonrpc": "2.0",
    "id": 1,
    "result": {
        "baseFeePerGas": "0x22f06c09",
        ...
    }
}

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Code review prechecks:

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Inline comments have been added for each method
  • I have made corresponding changes to the documentation
  • Code changes introduces no new problems or warnings
  • Test cases have been added
  • Dependent changes have been merged and published in downstream modules

@Lohann Lohann merged commit addcc66 into master Aug 18, 2023
@dvc94ch dvc94ch deleted the hotfix/upgrade-go-eth-version branch September 7, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants