HOTFIX: Auto reconnect for websocket connections #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, it fails to compile the tests in our self hosted instance, will investigate this later, at least locally it compiles fine. |
dvc94ch
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
about the ci sometimes not working, could be that we don't use the right self hosted runner, we have multiple now. Either that or the rust versions don't match. cc @penumbra23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ethereum provider doesn't attempt to reconnect after disconnect, this PR adds a basic thread-safe reconnect logic.
Type of change
Code review prechecks: