Issue-478: Rosetta Client talks directly to RPC nodes #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvc94ch
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
nice work! a lot of the "convolutions" are due to splitting responsibilities between the client (private key handling) and server (rpc handling). I think we can remove or aggregate most of the crates now. All that is needed is one crate per chain (combining config/tx/server) a core crate to define traits and types (for the chain crates), and the rosetta-client (main api), rosetta-wallet (cli tool), rosetta-docker (testing)
| @@ -11,6 +10,7 @@ pub use crate::mnemonic::{generate_mnemonic, MnemonicStore}; | |||
| pub use crate::signer::{RosettaAccount, RosettaPublicKey, Signer}; | |||
| pub use crate::wallet::EthereumExt; | |||
| pub use crate::wallet::Wallet; | |||
| use rosetta_core::BlockchainClient; | |||
| pub use rosetta_core::{crypto, types, BlockchainConfig, TransactionBuilder}; | |||
|
|
|||
| mod client; | |||
There was a problem hiding this comment.
Suggested change
| mod client; |
|
I'll merge so we can update timechain. Looking forward to having a radical reduction in complexity here soon! |
dvc94ch
deleted the
feature/issue-478-rosetta-client-talks-directly-to-rpc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows the rosetta-client crate to connect to the RPC node directly, eliminating the need of a connector as a service.
Part of https://github.com/Analog-Labs/testnet/issues/478
Type of change
Please delete options that are not relevant.
Code review prechecks: