Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup rosetta server dependencies #181

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Cleanup rosetta server dependencies #181

merged 3 commits into from
Sep 27, 2023

Conversation

Lohann
Copy link
Collaborator

@Lohann Lohann commented Sep 27, 2023

Description

Cleanup

  • Removes rosetta-wallet crate
  • Fix unit tests
  • Removes Dockerfiles and build_connectors.sh script

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Code review prechecks:

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Inline comments have been added for each method
  • I have made corresponding changes to the documentation
  • Code changes introduces no new problems or warnings
  • Test cases have been added
  • Dependent changes have been merged and published in downstream modules

@Lohann Lohann changed the title Refactor/remove rosetta server deps Cleanup rosetta server dependencies Sep 27, 2023
@Lohann Lohann merged commit 7d9a402 into master Sep 27, 2023
4 checks passed
@isabellelaususan isabellelaususan added connector Connector parent epic release-oct labels Sep 29, 2023
@Lohann Lohann deleted the refactor/remove-rosetta-server-deps branch October 30, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvc94ch dvc94ch dvc94ch approved these changes

@penumbra23 penumbra23 Awaiting requested review from penumbra23

Assignees
No one assigned
Labels
connector Connector parent epic release-oct
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lohann @dvc94ch @isabellelaususan