Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor rosetta-client interface #207

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

Lohann
Copy link
Collaborator

@Lohann Lohann commented Dec 11, 2023

Description

Removes method and function_selector from rosetta-client interfaces, also accept raw bytes instead of string as parameter.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link
Contributor

@dvc94ch dvc94ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like this is way more changes than what we needed. fine with me, but it's a bit late for an indepth review.

rosetta-client/src/tx_builder.rs Outdated Show resolved Hide resolved
rosetta-client/src/tx_builder.rs Outdated Show resolved Hide resolved
rosetta-client/src/tx_builder.rs Outdated Show resolved Hide resolved
rosetta-client/src/wallet.rs Outdated Show resolved Hide resolved
rosetta-client/src/wallet.rs Outdated Show resolved Hide resolved
rosetta-client/src/wallet.rs Outdated Show resolved Hide resolved
rosetta-client/src/wallet.rs Outdated Show resolved Hide resolved
rosetta-client/src/wallet.rs Outdated Show resolved Hide resolved
@Lohann Lohann merged commit 3e63904 into master Dec 12, 2023
8 checks passed
@Lohann Lohann deleted the feature/remove-unecessary-params-from-rosetta-client branch December 12, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants