-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rosetta cli changes according to new indexer #64
Conversation
README.md
Outdated
|
||
rosetta-cli --url=http://localhost:8081 --chain=eth search --indexer-url=http://localhost:8084 --type=Transfer --success=true | ||
|
||
rosetta-cli --url=http://localhost:8082 --chain=dot search --indexer-url=http://localhost:8085 --type=Transfer --success=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the url arg needed for here? or why do we need a new indexer-url arg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since the indexer will be running on a separate port than rosetta so i added the indexer-url. Should we add this in config? Url arg is for server default will connect to rosetta.analog.one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it will be running on a separate port. I think it would be better to forward the non search requests, it's a bit messy at the moment.
but my main question was, doesn't this work?
rosetta-cli --url=http://localhost:8085 --chain=dot search --type=Transfer --success=true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah right,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so i removed url arg from the readme file but would need that additional param in args to differentiate between rosetta-server url and rosetta-indexer url since we need both at somepoint.
Description
Changed implementation for rosetta-cli according to new indexer implementation
Type of change
Please delete options that are not relevant.
Tests
Describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Code review prechecks: