Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Webgo Provider #1102

Merged
merged 5 commits into from
Feb 13, 2022
Merged

Add Webgo Provider #1102

merged 5 commits into from
Feb 13, 2022

Conversation

mod242
Copy link
Contributor

@mod242 mod242 commented Jan 29, 2022

Created a new Provider for Webgo. This Hoster doesn't expose an regular API but an Webinterface.
My Implementation is heavily inspired by the henet provider.

@mod242 mod242 closed this Jan 29, 2022
@mod242 mod242 reopened this Jan 29, 2022
@mod242 mod242 marked this pull request as draft January 30, 2022 16:25
@mod242
Copy link
Contributor Author

mod242 commented Jan 30, 2022

Unfortunately I cam across one Problem when trying to implement my provider with acme.sh. Want to figure out what goes wrong here and will try to correct asap. Sorry for the noise, should have looked better before opening the pull-request

@mod242 mod242 marked this pull request as ready for review February 8, 2022 19:40
@mod242
Copy link
Contributor Author

mod242 commented Feb 8, 2022

I needed to add special handling for the main A-Record of an domain since this is handled very different by webgo

Copy link
Collaborator

@adferrand adferrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks a lot!

@adferrand adferrand merged commit b67a5e7 into AnalogJ:master Feb 13, 2022
MasinAD pushed a commit to MasinAD/lexicon that referenced this pull request Mar 29, 2022
* Add Webgo Provider

* Update Tests for Webgo

* Change Formatting

* Correction for Flake8

* Update Handling for Main DNS Entry

Co-authored-by: mb <michael.bruenker@nextevolution.de>
MasinAD pushed a commit to MasinAD/lexicon that referenced this pull request Mar 29, 2022
* Add Webgo Provider

* Update Tests for Webgo

* Change Formatting

* Correction for Flake8

* Update Handling for Main DNS Entry

Co-authored-by: mb <michael.bruenker@nextevolution.de>
MasinAD pushed a commit to MasinAD/lexicon that referenced this pull request Mar 29, 2022
* Add Webgo Provider

* Update Tests for Webgo

* Change Formatting

* Correction for Flake8

* Update Handling for Main DNS Entry

Co-authored-by: mb <michael.bruenker@nextevolution.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants