Fixed 3D Tiles refinement bug when skipLevelOfDetail is false #5869
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5814
This bug was introduced in #5788 which checks for a tile's visibility before loading it. This caused problems during the base-traversal step where it is expected that a replacement refinement tile loads all of its children, even if they are not visible. Otherwise the parent tile can never resolve.
This is not a problem with the internal-traversal (the skipping traversal), but since
skipLevelOfDetail=false
only uses the base-traversal it becomes a problem.This PR limits the visibility check to additive tiles only. I think the visibility check would also work with replacement tiles during the skip traversal, but in practice this only saves a few requests and I don't want to mess with anything else.