Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 3D Tiles refinement bug when skipLevelOfDetail is false #5869

Merged
merged 2 commits into from
Oct 2, 2017

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Oct 2, 2017

Fixes #5814

This bug was introduced in #5788 which checks for a tile's visibility before loading it. This caused problems during the base-traversal step where it is expected that a replacement refinement tile loads all of its children, even if they are not visible. Otherwise the parent tile can never resolve.

This is not a problem with the internal-traversal (the skipping traversal), but since skipLevelOfDetail=false only uses the base-traversal it becomes a problem.

This PR limits the visibility check to additive tiles only. I think the visibility check would also work with replacement tiles during the skip traversal, but in practice this only saves a few requests and I don't want to mess with anything else.

@cesium-concierge
Copy link

@lilleyse, thanks for the pull request! Maintainers, we have a signed CLA from @lilleyse, so you can review this at any time.

I am a bot who helps you make Cesium awesome! Thanks again.

@bagnell
Copy link
Contributor

bagnell commented Oct 2, 2017

Looks good to me.

@lilleyse Is there a reasonable test you can add?

@lilleyse
Copy link
Contributor Author

lilleyse commented Oct 2, 2017

Hmm I'll try to think of one.

@lilleyse
Copy link
Contributor Author

lilleyse commented Oct 2, 2017

Added a test, it checks the combined functionality of this PR, #5778, and #5788, which are all basically related.

@bagnell
Copy link
Contributor

bagnell commented Oct 2, 2017

Thanks @lilleyse!

@bagnell bagnell merged commit 9b05ee6 into master Oct 2, 2017
@bagnell bagnell deleted the traversal-fix branch October 2, 2017 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3D Tiles refinement broken when skip LODs is disabled
3 participants