-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hard normals #173
Hard normals #173
Conversation
…ne into hard-normals
…ne into hard-normals
…ne into hard-normals
…pipeline into hard-normals
Note: the material generation in |
Thanks @lasalvavida. @tfili once you confirm that this meets your needs, @lilleyse can review and merge. |
@lasalvavida this looks pretty good. The one issue we saw was you can't run this twice in a row because it either generates an invalid technique or we are missing an if check when processing a technique. |
@lasalvavida After a little digging the culprit seems to be the remove normals step. It removes the technique from the material so it can be regenerated, but there are stages before that happens that expect the technique to exist. |
Okay, I should have some time tomorrow to take a look at this. |
This should be fixed now |
…pipeline into support-b3dm
Please enter the commit message for your changes. Lines starting
@tfili let me know when this is all good from your end and I'll do a review. |
@lilleyse please merge when you are happy with the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removeBufferViews(gltf); | ||
removeBuffers(gltf); | ||
mergeBuffers(gltf); | ||
mergeDuplicateVertices(gltf); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since mergeDuplicateVertices
is the next step in Pipeline
we can remove it from here.
@@ -0,0 +1,9 @@ | |||
'use strict'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file used?
Preserve the existence of non-default shader attributes
@lilleyse I fixed you last 2 suggestions. Let me know if there is anything else. |
Thanks @tfili that should be it. |
@lasalvavida Just opening a pull request here so we can keep track of what needs to be done to get this in.
CC @pjcozzi