Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full yargs cli #170

Merged
merged 17 commits into from
Nov 11, 2016
Merged

Full yargs cli #170

merged 17 commits into from
Nov 11, 2016

Conversation

lasalvavida
Copy link
Contributor

@lasalvavida lasalvavida commented Sep 2, 2016

Uses yargs to fully establish default settings, types, etc. Makes the command line -h flag a lot more useful, and easier to maintain.

@lasalvavida
Copy link
Contributor Author

@lilleyse Could you look at this when you get a chance?

return;
}
var argv = require('yargs')
.usage('Usage: $0 -i inputPath -o outputPath')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the usage and example be like node $0?

@lilleyse
Copy link
Contributor

lilleyse commented Oct 3, 2016

Using yargs in this way is it possible to allow processing a file without -i and -o?

@lilleyse
Copy link
Contributor

lilleyse commented Oct 3, 2016

Looks good, just those comments.

@lasalvavida
Copy link
Contributor Author

This has been updated as well. 'node' has been added to the usage and help output. Input and output can also be passed implicitly as the first and second unmarked parameters without -i and -o. This will need a few updates if we merge #173 first.

@pjcozzi
Copy link
Contributor

pjcozzi commented Oct 31, 2016

Looks nice!

@lilleyse OK to merge?

@lilleyse
Copy link
Contributor

Only issue I'm noticing is it throws an error when no arguments are supplied. Should be a quick fix @lasalvavida and then I'll merge.

@lasalvavida
Copy link
Contributor Author

@lilleyse This is updated and merged with master.

@lasalvavida
Copy link
Contributor Author

@lilleyse Could you look at this when you get a chance?

@lilleyse
Copy link
Contributor

Ah thanks for the reminder, I did review the latest changes but must have gotten sidetracked.

@lilleyse lilleyse merged commit 707ca06 into master Nov 11, 2016
@lilleyse lilleyse deleted the full-yargs-cli branch November 11, 2016 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants