Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug & Suggestion: Sensor Node #28

Closed
marcus-j-davies opened this issue Aug 12, 2021 · 3 comments
Closed

Bug & Suggestion: Sensor Node #28

marcus-j-davies opened this issue Aug 12, 2021 · 3 comments
Labels
duplicate This issue or pull request already exists

Comments

@marcus-j-davies
Copy link

marcus-j-davies commented Aug 12, 2021

Hello,

Not been using this long, and so far, I really don't understand some things.

  1. Trigger (Sensor Node)
    Seems to completely ignore what I set, Any Message / msg.payload.open == true,
    I have passed this a payload of msg.payload.open = false and it triggers?
    Looking at the source code, triggerType does not seem to be utilised anywhere (at least from my investigation)?

    This is causing many false alarms

  2. Modes (Sensor Node)
    This tripped me up somewhat - I think this should be made more clear, as to what its intention is,
    Something like Armed In Modes.

    Admittedly, I perceived this as the states that alarm system supports (as opposed to what states the Sensor is Armed under)

    Lastly, any idea why Off is an option in what I call Armed In Modes?
    is it normal practice to arm a sensor when that alarm system is Off?

    Just seems odd.

@marcus-j-davies
Copy link
Author

Ok,

I guess this is no longer maintained.

@macinspak
Copy link
Contributor

macinspak commented Aug 17, 2021

Oh, definitely maintained, just not at that pace right now. Should leave the ticket open for someone to pick up.

Thanks for reporting it.

@macinspak
Copy link
Contributor

OK, Part 1 I think is best handled with a generic fix we are working on with #25 and I've moved part 2 to a new ticket #29

@macinspak macinspak added the duplicate This issue or pull request already exists label Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants