Sensor Node Modes - Confusion

[macinspak]

From #28 :

This tripped me up somewhat - I think this should be made more clear, as to what its intention is,
Something like Armed In Modes.

Admittedly, I perceived this as the states that alarm system supports (as opposed to what states the Sensor is Armed under)

Lastly, any idea why Off is an option in what I call Armed In Modes?
is it normal practice to arm a sensor when that alarm system is Off?

[macinspak]

@marcus-j-davies

For the first part: I think that is a great idea, we need to better label the field and add some commentary/instruction on what it does.

For the second part: The intent was to make the node as flexible as possible, so we simply enumerated all alarm "modes" in that selection field. There may be a use case where someone wants to use "Off" specifically to arm something, people who use the nodes then can include it if they want. Or just not use it.

I feel unless there is a really good reason to definitely exclude it (proof it is never possibly useful) then there is no harm including it? If you believe it should be removed, let us know how and we can discuss.

[marcus-j-davies]

Yes,

Modes vs Armed In Modes - in my opinion, can be viewed as 2 completely different things.
I initially viewed Modes as the modes that my system will support, so naturally selected them all, and was wondering why sensors were being triggered in an Off state

So I think there is room to improve this label.

Fair comment on the 'Off' option - I just would't have associated that to arming a sensor, but if flexibility is what you're going for, then I see why it's there.