Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension - Fix new (spring 2024) UI buttons position #1047

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

theblackhole
Copy link
Contributor

@theblackhole theblackhole commented Apr 19, 2024

With the new (spring 2024) UI, action buttons are aligned to the left but an obsolete patch make them align to the right instead.

This commit removes this obsolete patch in order to restore the original alignment (left for new UI and no changes/right for the previous UI).

Tested with the new and previous UI (Firefox and Edge on Windows) with and without the ratio bar

Screenshot of the issue:

What it's supposed to look like (RYD extension disabled) :

Screenshot of the provided fix:

With the new (spring 2024 UI), action buttons are aligned to the left but an obsolete patch made them align to the right instead.

This commit removes this obsolete patch in order to restore the original alignment (left for new UI and no changes/right for the previous UI)
@theblackhole theblackhole changed the title Extension - fix spring 2024 UI buttons position Extension - fix new (spring 2024) UI buttons position Apr 19, 2024
@theblackhole theblackhole changed the title Extension - fix new (spring 2024) UI buttons position Extension - Fix new (spring 2024) UI buttons position Apr 19, 2024
@theblackhole theblackhole mentioned this pull request Apr 19, 2024
1 task
@Anarios
Copy link
Owner

Anarios commented Jun 16, 2024

@theblackhole do you still experience the problem, is this patch still required?

I'm hesitant about removing older code - because many people can still have that version of UI.

@theblackhole
Copy link
Contributor Author

theblackhole commented Jun 20, 2024

@Anarios Unfortunately I don't have the new (spring 2024) UI anymore (I don't know why) so I can't tell if the patch is still required. But the current UI (before this big layout change) isn't affected by this patch, I think this was for an even older version of the UI

@theblackhole
Copy link
Contributor Author

@leakedmemory In your screenshot, return-youtube-dislike doesn't work at all 😅

@leakedmemory
Copy link

leakedmemory commented Jun 28, 2024

@theblackhole Indeed, that was when I thought the bug of #1037 was not interfering with this, but I'm wrong. This still happens and that other bug too, so I'm gonna remove my other comment. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants