User script user options #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
introduce user options to userscript. Using existing options available in extension for now, plus showing update popup. Part of Anarios#539
using user options Anarios#539 resolves Anarios#520
using user options Anarios#539
cyrildtm
added a commit
to cyrildtm/return-youtube-dislike
that referenced
this pull request
Apr 20, 2022
Userscript custom colors using user options Anarios#539 Userscript user options introduce user options to userscript. Using existing options available in extension for now, plus showing update popup. Part of Anarios#539 userscript custom number formats using user options Anarios#539 resolves Anarios#520
ErykDarnowski
approved these changes
Apr 23, 2022
| colorString = "magenta"; | ||
| } | ||
| break; | ||
| case "classic": |
There was a problem hiding this comment.
Hey I'm wondering why did you use case "classic": here when there's already default:?
cyrildtm
added a commit
to cyrildtm/return-youtube-dislike
that referenced
this pull request
Apr 24, 2022
Userscript custom colors using user options Anarios#539 Userscript user options introduce user options to userscript. Using existing options available in extension for now, plus showing update popup. Part of Anarios#539 userscript custom number formats using user options Anarios#539 resolves Anarios#520
cyrildtm
added a commit
to cyrildtm/return-youtube-dislike
that referenced
this pull request
Apr 24, 2022
cyrildtm
added a commit
to cyrildtm/return-youtube-dislike
that referenced
this pull request
Apr 24, 2022
Userscript custom colors using user options Anarios#539 Userscript user options introduce user options to userscript. Using existing options available in extension for now, plus showing update popup. Part of Anarios#539 userscript custom number formats using user options Anarios#539 resolves Anarios#520
cyrildtm
added a commit
to cyrildtm/return-youtube-dislike
that referenced
this pull request
Apr 24, 2022
(userscript) fix shorts thumb colors related: Anarios#540 (extension) fix shorts thumb colors fix Anarios#565
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduce user options to userscript. Using existing options available in extension for now, plus showing update popup.
Resolves #520
Not implemented features but with options: disable vote submission, show update popup.
Part of #539