-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User script user options #540
Conversation
introduce user options to userscript. Using existing options available in extension for now, plus showing update popup. Part of Anarios#539
using user options Anarios#539 resolves Anarios#520
using user options Anarios#539
Userscript custom colors using user options Anarios#539 Userscript user options introduce user options to userscript. Using existing options available in extension for now, plus showing update popup. Part of Anarios#539 userscript custom number formats using user options Anarios#539 resolves Anarios#520
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! Besides the first 2 values in extConfig (showUpdatePopup and disableVoteSubmission) that aren't implemented yet, everything looks great ;)
colorString = "magenta"; | ||
} | ||
break; | ||
case "classic": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey I'm wondering why did you use case "classic":
here when there's already default:
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clarity.
Userscript custom colors using user options Anarios#539 Userscript user options introduce user options to userscript. Using existing options available in extension for now, plus showing update popup. Part of Anarios#539 userscript custom number formats using user options Anarios#539 resolves Anarios#520
Userscript custom colors using user options Anarios#539 Userscript user options introduce user options to userscript. Using existing options available in extension for now, plus showing update popup. Part of Anarios#539 userscript custom number formats using user options Anarios#539 resolves Anarios#520
(userscript) fix shorts thumb colors related: Anarios#540 (extension) fix shorts thumb colors fix Anarios#565
introduce user options to userscript. Using existing options available in extension for now, plus showing update popup.
Resolves #520
Not implemented features but with options: disable vote submission, show update popup.
Part of #539