Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put code together with Anas #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

put code together with Anas #1

wants to merge 5 commits into from

Conversation

kaiyue0329
Copy link
Collaborator

@kaiyue0329 kaiyue0329 commented Jun 17, 2020

engine-tag draft

Signed-off-by: Kaiyue Pan <kaiyue.pan@ericsson.com>
@Anasshahidd21 Anasshahidd21 force-pushed the engine-tag branch 4 times, most recently from 22a740b to 8a730ec Compare June 18, 2020 16:55
Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Kaiyue Pan added 2 commits June 18, 2020 16:20
- Query all versions of the extension from open-vsx api
- Find the latest compatible version by checking each version's 'engines.vscode' value
- Hide the extension from the search result if no compatible version is found

Signed-off-by: Kaiyue Pan <kaiyue.pan@ericsson.com>
Signed-off-by: Kaiyue Pan <kaiyue.pan@ericsson.com>
@Anasshahidd21 Anasshahidd21 marked this pull request as ready for review June 20, 2020 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant