Using std::thread to implement Thread.

[nicber]

Hi

I'm trying to port rct to MSVC and one the many changes I need to make is porting Thread to Windows.

I have thought about replacing it's current implementation with a thin wrapper around std::thread. And using native_handle to implement support for priorities.

Would it be ok to do this? Is there any particular reason why Thread is implemented the way it is?

[Andersbakken]

I think that would be fine.

…

On Tue, Aug 22, 2017 at 3:59 PM nicber ***@***.***> wrote: Hi I'm trying to port rct to MSVC and one the many changes I need to make is porting Thread to Windows. I have thought about replacing it's current implementation with a thin wrapper around std::thread. And using native_handle to implement support for priorities. Would it be ok to do this? Is there any particular reason why Thread is implemented the way it is? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#70>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEdSssTqtEc82W5ZLqS01g0bDu49s6Cks5sa11UgaJpZM4O_SXn> .

[nicber]

I think it is not possible to change the stack size before thread creation using the std::thread API.
I have seen that feature is used in rtags in only one place.
Do you think it is really necessary to run rtags on Windows?

[Andersbakken]

It think it's fine if the windows port of rct ignores stack size for threads quite frankly. According to this we needed to increase the size on Mac for dump thread to work. If all else fails we could probably do something like changing the default thread stack size to something larger on windows or something. It's entirely poissble that we don't even need this anymore. Anders

…

On Tue, Aug 22, 2017 at 4:45 PM, nicber ***@***.***> wrote: I think it is not possible to change the stack size before thread creation using the std::thread API. I have seen that feature is used in rtags in only one place. Do you think it is really necessary to run rtags on Windows? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#70 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEdSsfehBJW3-kDGd-wnOgnuqOZqTvHks5sa2gYgaJpZM4O_SXn> .

[Andersbakken]

According to this I meant: 24a6b22519839fa7bb9b838a2d118c92c0088948

…

On Tue, Aug 22, 2017 at 5:16 PM, Anders Bakken ***@***.***> wrote: It think it's fine if the windows port of rct ignores stack size for threads quite frankly. According to this we needed to increase the size on Mac for dump thread to work. If all else fails we could probably do something like changing the default thread stack size to something larger on windows or something. It's entirely poissble that we don't even need this anymore. Anders On Tue, Aug 22, 2017 at 4:45 PM, nicber ***@***.***> wrote: > I think it is not possible to change the stack size before thread > creation using the std::thread API. > I have seen that feature is used in rtags in only one place. > Do you think it is really necessary to run rtags on Windows? > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#70 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAEdSsfehBJW3-kDGd-wnOgnuqOZqTvHks5sa2gYgaJpZM4O_SXn> > . >

[Gei0r]

nicber, it would probably be best if you base your work on my win branch, so we don't duplicate work.