Moved directory check into try-catch block #20

take care of the scope of fileInfo
AndiDittrich · Nov 30, 2016 · ff6999b · ff6999b
1 parent 709ecd7
commit ff6999b
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/lib/NodeMCU-Tool.js b/lib/NodeMCU-Tool.js
@@ -142,19 +142,20 @@ Tool.upload = function(localFiles, options, onProgess){
         // get file stats
         try{
             var fileInfo = _fs.statSync(localFile);
+
+            // check if file is directory
+            if (fileInfo.isDirectory()) {
+                _mculogger.error('Path "' + localFile + '" is a directory.');
+                onComplete();
+                return;
+            }
+
         // local file available
         } catch (err){
             _logger.error('Local file not found "' + localFile + '" skipping...');
             onComplete();
             return;
         }
-
-        // check if file is directory
-        if (fileInfo.isDirectory()) {
-            _mculogger.error('Path "' + localFile + '" is a directory.');
-            onComplete();
-            return;
-        }
 
         // display filename
         _logger.log('Uploading "' + localFile + '" >> "' + remoteFilename + '"...');