Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update on new multiline height #49

Open
ryandury opened this issue Mar 5, 2017 · 6 comments
Open

Update on new multiline height #49

ryandury opened this issue Mar 5, 2017 · 6 comments

Comments

@ryandury
Copy link

ryandury commented Mar 5, 2017

Hey, any support for multilines that adapt to the content height? I've got a listener on my TextInput that will adjust itself based on the content height. The KeyboardSpacer doesn't appear to adjust height based on the new height of the multiline.

@Andr3wHur5t
Copy link
Owner

Hmm, I don't think I understand your situation.

The keyboard spacer in most situations should only need to accommodate the keyboard.

Can you post a screenshot or gif?

@charlle
Copy link

charlle commented Apr 11, 2017

@Andr3wHur5t the Keyboard Spacer needs: componentWillReceiveProps to allow topSpacing to receive a dynamic property, which will update the Keyboard spacing. This will solve @ryandury problem.

@Andr3wHur5t
Copy link
Owner

@charlle wouldn't the input be on top of the keyboard?

Unless I'm missing something, I would think that top spacing would only create a gap between the keyboard and the input.

@wrightmk
Copy link

@charlle Could you explain your answer a little further. I'm also having a similar problem when using KeyboardSpacer in conjunction with TabNavigator from react-navigation. As it stands, the text area is raised above the keyboard the same distance as the tab navigator.

@benevbright
Copy link

Same problem when I'm using TabNavigator. Any update?

@timnovis
Copy link

timnovis commented Jun 5, 2018

Sorry to resurrect such an old issue, but I'm also having the same issue when using this module with React Navigation inside a TabNavigator view.

screen shot 2018-06-05 at 13 12 59

Is there a solution I've missed?

SnaiNeR added a commit to maxiru/react-native-keyboard-spacer that referenced this issue Jun 10, 2020
Andr3wHur5t#56
A fix for Andr3wHur5t#49. I tried to avoid manually writing a componentWillReceiveProps function to keep the code simpler.
SnaiNeR added a commit to maxiru/react-native-keyboard-spacer that referenced this issue Jun 10, 2020
Andr3wHur5t#56
A fix for Andr3wHur5t#49. I tried to avoid manually writing a componentWillReceiveProps function to keep the code simpler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants