Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Adding IChannelAudioVolume interface #87

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

mltony
Copy link
Contributor

@mltony mltony commented Feb 9, 2024

Hello! I am one of developers of NVDA - a screenreader for the blind. We would like to make use of pycaw for soundSplit feature: that involves setting volume for left and right channel separately. However I found that IChannelAudioVolume interface from core audio API is not present, so I would like to add it.

For more context see nvaccess/nvda#16071.

Thanks!

@mltony mltony mentioned this pull request Feb 9, 2024
5 tasks
Copy link
Owner

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll merge after the CI is done.
Don't worry about the linter, the version changed and all files need to be linted.
I'll do that post merge
Edit: CI is struggling, will merge anyway

@AndreMiras AndreMiras merged commit 0259e0e into AndreMiras:develop Feb 10, 2024
0 of 5 checks passed
@mltony
Copy link
Contributor Author

mltony commented Feb 11, 2024

Thanks @AndreMiras for merging this so quickly!

@AndreMiras
Copy link
Owner

Thanks for contributing. I hope you'll be able to integrate it flawlessly with nvda.
I'd love to make an release, but ideally I should fix the CI misbehaving lately.

@TJ-59 TJ-59 mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants