Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Backup and Unit option #123

Merged
merged 18 commits into from
Nov 17, 2023
Merged

Improved Backup and Unit option #123

merged 18 commits into from
Nov 17, 2023

Conversation

AndreWohnsland
Copy link
Owner

This PR implements:

  • Unit option for the ingredients
  • Displays for other views

Additional improvements:

  • Own window for backups
  • Displays everything inside the backup
  • User can choose what to back up
  • Adjust docs

Copy link

@code-review-doctor code-review-doctor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things to consider. View full project report here.

@@ -43,6 +43,18 @@ class RecipeInput:
virgin: int


@dataclass

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@dataclass
@dataclass(frozen=True)

Use frozen=True to make the dataclasses immutable and hashable. More info.

Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AndreWohnsland AndreWohnsland merged commit c84b498 into master Nov 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant